switch data representation in python wrapper #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From column-major order to row-major order
|
My memory did not deceive me... a fix exists for #22! But it never got merged. Is there anything blocking it? |
|
I've never merged this because I was never too sure of the implications with FITS files and with pyMilk, precisely what C/F style assumptions are made in which layer and how this PR relaxes them (basically what I was saying in #22, and I never really dug deeper). I guess as long as we can maintain guarantees between python and ISIO, we should be good. However, #22 has been fixed at the pyMilk level at the cost of a copy in the case that was causing the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From column-major order to row-major order
It should fix the issue #22 and remove the transpose in pyMilk